Fix syntax error in the bash script regarding LD_LIBRARY_PATH#1624
Open
fairyfar wants to merge 1 commit intoapache:mainfrom
Open
Fix syntax error in the bash script regarding LD_LIBRARY_PATH#1624fairyfar wants to merge 1 commit intoapache:mainfrom
fairyfar wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
Hi @fairyfar thanks for your work! Could you share the bash/OS version or other related info? I want to reproduce it. Thanks! |
Contributor
Author
|
leborchuk
approved these changes
Mar 20, 2026
Contributor
leborchuk
left a comment
leborchuk
left a comment
There was a problem hiding this comment.
Yes, it should be fixed.
I think parameter with default value syntax should work only in bash https://linux.die.net/man/1/bash
${parameter:-word}
Use Default Values. If parameter is unset or null, the expansion of word is substituted. Otherwise, the value of parameter is substituted.
And we use bash in all our scripts, all should be Ok
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix syntax error in the bash script regarding LD_LIBRARY_PATH.
Some of bash scripts or commands missed the symbol '$' when referencing LD_LIBRARY_PATH.
In addition, the corresponding product manual also has the same careless omission. Such as (only a part of it):
https://cloudberry.apache.org/docs/deployment/quick-build
https://cloudberry.apache.org/docs/next/deployment/configure
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions